feat(l2): batch reversion #3136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
iovoid
force-pushed
the
feat/revert-batch
branch
from
fcb4138 to
622f6d6
Compare
cmd/ethrex/l2/command.rs
Outdated
Comment on lines
509
to
528
| async fn call_contract( | ||
| client: &EthClient, | ||
| private_key: &SecretKey, | ||
| to: Address, | ||
| signature: &str, | ||
| parameters: Vec<Value>, | ||
| ) -> eyre::Result<()> { | ||
| let calldata = encode_calldata(signature, ¶meters)?.into(); | ||
| let from = get_address_from_secret_key(private_key)?; | ||
| let tx = client | ||
| .build_eip1559_transaction(to, from, calldata, Default::default()) | ||
| .await?; | ||
|
|
||
| let tx_hash = client.send_eip1559_transaction(&tx, private_key).await?; | ||
|
|
||
| info!("TxID: {tx_hash:#x}",); | ||
|
|
||
| wait_for_transaction_receipt(tx_hash, client, 100).await?; | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Maybe this should go in the SDK
There was a problem hiding this comment.
+1. We may have something like this already, I don't remember.
|
I'd add some integration tests or file an issue for doing so in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As outlined in #3124, sometimes a committed batch can't be verified or the operator wants to prevent it from going though.
Description
This PR implements a
revertBatchfunction that allows reverting back to any batch, as long as no verified batches are being discarded.There's also a l2 CLI subcommand, revert-batch that lets you revert a batch and remove it from the local database.
Usage on local network:
Closes #3124