chore(l2): remove save state module #3119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xqft
force-pushed
the
l2/remove_save_state
branch
from
5d03964 to
f26f67a
Compare
Lines of code reportTotal lines added: Detailed view |
LeanSerra
reviewed
Jun 12, 2025
Comment on lines
+460
to
+478
| // Check if we have a proof for this batch and prover type | ||
| let prover_type = batch_proof.prover_type(); | ||
| if state | ||
| .rollup_store | ||
| .get_proof_by_batch_and_type(batch_number, prover_type) | ||
| .await? | ||
| .is_some() | ||
| { | ||
| info!( | ||
| ?batch_number, | ||
| ?prover_type, | ||
| "A proof was received for a batch and type that is already stored" | ||
| ); | ||
| } else { | ||
| write_state(batch_number, &StateType::BatchProof(batch_proof))?; | ||
| // If not, store it | ||
| state | ||
| .rollup_store | ||
| .store_proof_by_batch_and_type(batch_number, prover_type, batch_proof) | ||
| .await?; |
There was a problem hiding this comment.
This is just a question but is there any reason to not overwrite the proof with the new one we receive instead of checking if we already have one
There was a problem hiding this comment.
I don't think so, both options are as valid, and this was the behavior before my changes
xqft
force-pushed
the
l2/remove_save_state
branch
from
1e7b0ee to
5356d00
Compare
LeanSerra
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The save state module was unnecessarily complex for what it achieved (storing incoming batch proofs). This PR replaces it with the rollup store.
Description
ethex-l2-commonbecauseethrex-storage-rollupcan't depend on the prover because of cyclic dependenciesValuetype intoethrex-l2-commonbecauseethrex-l2-commoncan't depend onethrex-sdk