Skip to content

Fix secp-hints CI jobs #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

gabrielbosio
Copy link
Collaborator

Cherry-picks the minimum amount of commits from main to fix secp-hints CI jobs.

* Update cairo-lang versin

* Update changelog

* Add new hints

* Specify prime in new hints

* Only apply mod floor if prime is not CAIRO_PRIME

* Properly implement pack for a different prime

* Fix pack in compute_doubling_slope

* Add negative_points.cairo test

* Add try_get_point_from_x for negative points

* Add double_x test for negative points

* Allow to many arguments

* Add codecov to cairo-0-secp-hints feature
@gabrielbosio gabrielbosio changed the base branch from main to starkware-development June 5, 2025 14:20
@gabrielbosio gabrielbosio changed the title Sync with main Fix secp-hints CI jobs Jun 5, 2025
@gabrielbosio gabrielbosio marked this pull request as ready for review June 5, 2025 14:27
@gabrielbosio gabrielbosio added the nochangelog Skip the changelog check label Jun 5, 2025
@gabrielbosio
Copy link
Collaborator Author

Added the nochangelog label because this is getting merged to starkware-development.

Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielbosio gabrielbosio merged commit bdf604f into starkware-development Jun 5, 2025
1 of 2 checks passed
@gabrielbosio gabrielbosio deleted the sync_with_main branch June 5, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nochangelog Skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants