Use_btreemap_for_deterministic_order_of_pie_keys

[YairVaknin-starkware]

TITLE

Description

Description of the pull request changes and motivation.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

---

This change is 

[github-actions]

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.420 s ±  0.007 s    [User: 25.639 s, System: 0.778 s]
  Range (min … max):   26.415 s … 26.425 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.723 s ±  0.065 s    [User: 25.904 s, System: 0.815 s]
  Range (min … max):   26.678 s … 26.769 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.631 s ±  0.049 s    [User: 25.758 s, System: 0.785 s]
  Range (min … max):   14.596 s … 14.665 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.908 s ±  0.043 s    [User: 25.968 s, System: 0.872 s]
  Range (min … max):   14.877 s … 14.938 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.02 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.660 s ±  0.445 s    [User: 37.785 s, System: 0.989 s]
  Range (min … max):   10.345 s … 10.975 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.745 s ±  0.262 s    [User: 38.006 s, System: 1.062 s]
  Range (min … max):   10.560 s … 10.931 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.01 ± 0.05 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.357 s ±  0.167 s    [User: 38.095 s, System: 0.973 s]
  Range (min … max):   10.239 s … 10.475 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.802 s ±  0.085 s    [User: 38.437 s, System: 1.121 s]
  Range (min … max):   10.742 s … 10.862 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.04 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.392 s ±  0.019 s    [User: 38.169 s, System: 1.056 s]
  Range (min … max):   10.378 s … 10.405 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.481 s ±  0.098 s    [User: 38.703 s, System: 1.098 s]
  Range (min … max):   10.412 s … 10.550 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.488 s ±  0.137 s    [User: 38.358 s, System: 1.118 s]
  Range (min … max):   10.390 s … 10.585 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.518 s ±  0.233 s    [User: 38.977 s, System: 1.221 s]
  Range (min … max):   10.353 s … 10.683 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.00 ± 0.03 times faster than hyper_threading_pr threads: 16

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.111 ± 0.006	2.102	2.119	1.00
head big_factorial	2.130 ± 0.022	2.111	2.188	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	2.054 ± 0.008	2.044	2.072	1.00
head big_fibonacci	2.059 ± 0.017	2.041	2.096	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	7.872 ± 0.031	7.823	7.910	1.00 ± 0.01
head blake2s_integration_benchmark	7.860 ± 0.036	7.806	7.912	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.180 ± 0.009	2.165	2.191	1.00 ± 0.01
head compare_arrays_200000	2.175 ± 0.012	2.156	2.188	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.414 ± 0.007	1.402	1.425	1.00
head dict_integration_benchmark	1.424 ± 0.010	1.416	1.451	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.222 ± 0.005	1.216	1.230	1.00
head field_arithmetic_get_square_benchmark	1.239 ± 0.005	1.231	1.246	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	7.960 ± 0.095	7.891	8.201	1.01 ± 0.01
head integration_builtins	7.911 ± 0.049	7.860	8.023	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	8.166 ± 0.056	8.111	8.309	1.00
head keccak_integration_benchmark	8.235 ± 0.112	8.143	8.503	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.169 ± 0.014	2.150	2.203	1.00
head linear_search	2.170 ± 0.023	2.155	2.234	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.512 ± 0.010	1.496	1.536	1.00
head math_cmp_and_pow_integration_benchmark	1.525 ± 0.006	1.510	1.530	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.460 ± 0.008	1.450	1.479	1.00
head math_integration_benchmark	1.484 ± 0.018	1.470	1.523	1.02 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.217 ± 0.008	1.208	1.237	1.00
head memory_integration_benchmark	1.217 ± 0.005	1.209	1.226	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.563 ± 0.009	1.551	1.575	1.00
head operations_with_data_structures_benchmarks	1.586 ± 0.009	1.575	1.603	1.01 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	532.8 ± 1.9	530.0	536.4	1.01 ± 0.00
head pedersen	530.2 ± 1.7	527.8	533.0	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base poseidon_integration_benchmark	626.0 ± 3.8	621.5	633.9	1.00
head poseidon_integration_benchmark	627.9 ± 7.0	615.9	641.6	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	1.856 ± 0.008	1.839	1.872	1.01 ± 0.01
head secp_integration_benchmark	1.833 ± 0.011	1.819	1.852	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base set_integration_benchmark	625.8 ± 1.8	623.4	629.3	1.00
head set_integration_benchmark	627.3 ± 3.7	621.3	634.2	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	4.312 ± 0.052	4.269	4.453	1.00
head uint256_integration_benchmark	4.317 ± 0.011	4.298	4.330	1.00 ± 0.01

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (33d75ca) to head (a0b63e4).
Report is 1 commits behind head on starkware-development.

Additional details and impacted files

@@                    Coverage Diff                    @@
##           starkware-development    #2085      +/-   ##
=========================================================
- Coverage                  96.62%   96.52%   -0.10%     
=========================================================
  Files                        102      102              
  Lines                      44388    43198    -1190     
=========================================================
- Hits                       42889    41697    -1192     
- Misses                      1499     1501       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[OmriEshhar1]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @YairVaknin-starkware)