-
Notifications
You must be signed in to change notification settings - Fork 187
use bincode for faster writing prover input info #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use bincode for faster writing prover input info #2074
Conversation
26e1cd4
to
76555e7
Compare
|
Benchmark Results for unmodified programs 🚀
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## starkware-development #2074 +/- ##
=========================================================
- Coverage 96.63% 96.52% -0.12%
=========================================================
Files 102 102
Lines 44374 43198 -1176
=========================================================
- Hits 42881 41697 -1184
- Misses 1493 1501 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Stavbe, I left you some small comments.
Hi @Stavbe, I have some questions:
I'm asking this because the idea is to keep the number of dependencies at a minimum. |
28da242
to
ad1214c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to create binary file for this sturct. Changed to use bincode::serde instead of postcard.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @DavidLevitGurevich and @JulianGCalderon)
de8e050
to
2726e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @JulianGCalderon)
vm/src/vm/runners/cairo_runner.rs
line 1581 at r1 (raw file):
#[error("Failed to (de)serialize data")] SerdeBincode(#[from] bincode::error::EncodeError), #[error("Failed to (de)serialize data using postcard")]
postcard?
2726e58
to
58174f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @JulianGCalderon)
Added another flag to allow fast serialization of 'prover_input_info' into binary file
This change is