Add_perp_and_dex_w_bitwise_layouts

[YairVaknin-starkware]

TITLE

Description

Description of the pull request changes and motivation.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

[github-actions]

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.384 s ±  0.048 s    [User: 25.640 s, System: 0.742 s]
  Range (min … max):   26.350 s … 26.417 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.650 s ±  0.003 s    [User: 25.832 s, System: 0.815 s]
  Range (min … max):   26.647 s … 26.652 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.926 s ±  0.301 s    [User: 25.975 s, System: 0.771 s]
  Range (min … max):   14.713 s … 15.139 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.838 s ±  0.012 s    [User: 25.855 s, System: 0.847 s]
  Range (min … max):   14.830 s … 14.847 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.551 s ±  0.429 s    [User: 37.721 s, System: 0.936 s]
  Range (min … max):   10.247 s … 10.854 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.888 s ±  0.090 s    [User: 38.391 s, System: 1.024 s]
  Range (min … max):   10.824 s … 10.952 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.03 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.648 s ±  0.092 s    [User: 37.746 s, System: 0.964 s]
  Range (min … max):   10.583 s … 10.713 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.590 s ±  0.224 s    [User: 39.182 s, System: 1.025 s]
  Range (min … max):   10.432 s … 10.748 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.234 s ±  0.157 s    [User: 38.372 s, System: 0.991 s]
  Range (min … max):   10.123 s … 10.345 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.908 s ±  0.445 s    [User: 39.034 s, System: 1.037 s]
  Range (min … max):   10.593 s … 11.223 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.07 ± 0.05 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.443 s ±  0.304 s    [User: 38.617 s, System: 1.068 s]
  Range (min … max):   10.228 s … 10.658 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.883 s ±  0.055 s    [User: 39.360 s, System: 1.099 s]
  Range (min … max):   10.844 s … 10.921 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.04 ± 0.03 times faster than hyper_threading_pr threads: 16

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.135 ± 0.008	2.125	2.149	1.00
head big_factorial	2.137 ± 0.019	2.119	2.187	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	2.063 ± 0.017	2.051	2.106	1.00
head big_fibonacci	2.080 ± 0.022	2.047	2.132	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	7.984 ± 0.161	7.819	8.321	1.00 ± 0.02
head blake2s_integration_benchmark	7.946 ± 0.100	7.841	8.166	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.198 ± 0.017	2.179	2.235	1.00
head compare_arrays_200000	2.202 ± 0.011	2.187	2.220	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.431 ± 0.014	1.419	1.468	1.00
head dict_integration_benchmark	1.443 ± 0.010	1.434	1.466	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.236 ± 0.008	1.229	1.258	1.00
head field_arithmetic_get_square_benchmark	1.238 ± 0.012	1.227	1.269	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	7.962 ± 0.097	7.884	8.230	1.00
head integration_builtins	7.968 ± 0.044	7.891	8.022	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	8.233 ± 0.087	8.165	8.406	1.00
head keccak_integration_benchmark	8.295 ± 0.055	8.216	8.351	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.186 ± 0.027	2.170	2.261	1.01 ± 0.01
head linear_search	2.172 ± 0.017	2.146	2.206	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.511 ± 0.007	1.504	1.527	1.00
head math_cmp_and_pow_integration_benchmark	1.511 ± 0.008	1.499	1.519	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.460 ± 0.009	1.449	1.483	1.00
head math_integration_benchmark	1.479 ± 0.008	1.466	1.494	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.220 ± 0.021	1.204	1.261	1.00
head memory_integration_benchmark	1.225 ± 0.019	1.207	1.271	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.573 ± 0.005	1.569	1.587	1.00
head operations_with_data_structures_benchmarks	1.583 ± 0.007	1.573	1.595	1.01 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	533.8 ± 0.8	532.6	535.1	1.00 ± 0.00
head pedersen	533.1 ± 2.5	531.3	540.0	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base poseidon_integration_benchmark	633.0 ± 3.5	630.7	642.7	1.00
head poseidon_integration_benchmark	639.2 ± 5.5	634.1	649.7	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	1.872 ± 0.011	1.863	1.891	1.00
head secp_integration_benchmark	1.878 ± 0.013	1.865	1.904	1.00 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base set_integration_benchmark	662.0 ± 3.9	655.2	666.9	1.05 ± 0.01
head set_integration_benchmark	631.4 ± 1.9	628.3	634.0	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	4.309 ± 0.029	4.282	4.379	1.00 ± 0.01
head uint256_integration_benchmark	4.307 ± 0.025	4.271	4.342	1.00

[codecov]

Codecov Report

Attention: Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.53%. Comparing base (b9330cd) to head (4f54461).
Report is 3 commits behind head on starkware-development.

Files with missing lines	Patch %	Lines
vm/src/vm/runners/cairo_runner.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##           starkware-development    #2067   +/-   ##
======================================================
  Coverage                  96.53%   96.53%           
======================================================
  Files                        102      102           
  Lines                      43096    43175   +79     
======================================================
+ Hits                       41603    41680   +77     
- Misses                      1493     1495    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[yuvalsw]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @YairVaknin-starkware)