Skip to content

Stav/disable trace padding for prover input info #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Stavbe
Copy link
Collaborator

@Stavbe Stavbe commented Apr 10, 2025

Set disable trace padding flag if prover input info is required.
Note that this flag only affects in proof mode.


This change is Reviewable

@Stavbe Stavbe self-assigned this Apr 10, 2025
@Stavbe Stavbe marked this pull request as ready for review April 10, 2025 15:23
Copy link

github-actions bot commented Apr 10, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.414 s ±  0.025 s    [User: 25.625 s, System: 0.786 s]
  Range (min … max):   26.396 s … 26.432 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.978 s ±  0.119 s    [User: 26.124 s, System: 0.851 s]
  Range (min … max):   26.893 s … 27.062 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.02 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.811 s ±  0.133 s    [User: 25.819 s, System: 0.831 s]
  Range (min … max):   14.717 s … 14.905 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     15.044 s ±  0.046 s    [User: 26.111 s, System: 0.925 s]
  Range (min … max):   15.011 s … 15.076 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.02 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.621 s ±  0.359 s    [User: 37.684 s, System: 0.944 s]
  Range (min … max):   10.367 s … 10.875 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.229 s ±  0.033 s    [User: 38.705 s, System: 1.013 s]
  Range (min … max):   11.205 s … 11.252 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.06 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.466 s ±  0.286 s    [User: 38.115 s, System: 0.963 s]
  Range (min … max):   10.264 s … 10.668 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.980 s ±  0.050 s    [User: 38.627 s, System: 1.075 s]
  Range (min … max):   10.945 s … 11.016 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.05 ± 0.03 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.451 s ±  0.057 s    [User: 38.163 s, System: 1.000 s]
  Range (min … max):   10.410 s … 10.491 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.598 s ±  0.069 s    [User: 39.460 s, System: 1.101 s]
  Range (min … max):   10.549 s … 10.647 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.443 s ±  0.240 s    [User: 38.868 s, System: 1.089 s]
  Range (min … max):   10.273 s … 10.612 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.677 s ±  0.276 s    [User: 39.780 s, System: 1.183 s]
  Range (min … max):   10.483 s … 10.872 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.02 ± 0.04 times faster than hyper_threading_pr threads: 16


Copy link

github-actions bot commented Apr 10, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 1.987 ± 0.028 1.964 2.044 1.00 ± 0.02
head big_factorial 1.984 ± 0.023 1.960 2.035 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 1.916 ± 0.007 1.903 1.931 1.00 ± 0.01
head big_fibonacci 1.911 ± 0.008 1.900 1.929 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.351 ± 0.075 7.277 7.526 1.01 ± 0.01
head blake2s_integration_benchmark 7.300 ± 0.079 7.219 7.496 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.052 ± 0.017 2.031 2.094 1.01 ± 0.02
head compare_arrays_200000 2.032 ± 0.026 2.011 2.092 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.338 ± 0.014 1.329 1.374 1.00
head dict_integration_benchmark 1.340 ± 0.007 1.333 1.356 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.149 ± 0.015 1.137 1.186 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.143 ± 0.004 1.137 1.149 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.379 ± 0.023 7.343 7.411 1.00
head integration_builtins 7.390 ± 0.080 7.330 7.603 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.724 ± 0.124 7.570 7.926 1.01 ± 0.02
head keccak_integration_benchmark 7.612 ± 0.061 7.563 7.777 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.026 ± 0.012 2.011 2.049 1.00 ± 0.01
head linear_search 2.021 ± 0.011 2.007 2.044 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.409 ± 0.015 1.399 1.449 1.00
head math_cmp_and_pow_integration_benchmark 1.412 ± 0.012 1.400 1.444 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.350 ± 0.006 1.342 1.357 1.00
head math_integration_benchmark 1.358 ± 0.007 1.351 1.374 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.124 ± 0.005 1.117 1.132 1.00
head memory_integration_benchmark 1.130 ± 0.010 1.119 1.152 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.461 ± 0.010 1.452 1.481 1.00
head operations_with_data_structures_benchmarks 1.472 ± 0.008 1.466 1.490 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 495.4 ± 1.9 493.1 499.8 1.00
head pedersen 497.5 ± 6.7 493.2 515.9 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 582.0 ± 3.9 575.4 588.2 1.00
head poseidon_integration_benchmark 582.6 ± 4.1 577.0 593.2 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.730 ± 0.006 1.723 1.745 1.00
head secp_integration_benchmark 1.742 ± 0.016 1.727 1.771 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 626.0 ± 3.9 622.1 634.3 1.02 ± 0.02
head set_integration_benchmark 612.4 ± 8.4 604.8 630.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.983 ± 0.012 3.967 4.005 1.00
head uint256_integration_benchmark 4.010 ± 0.010 3.994 4.024 1.01 ± 0.00

Copy link
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich)


-- commits line 0 at r1:
move to starkware-development. Is it on top of main on purpose?

@gabrielbosio
Copy link
Collaborator

Hi, @Stavbe, should this PR target main?

@Stavbe Stavbe changed the base branch from main to starkware-development April 14, 2025 07:34
Copy link
Collaborator Author

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich and @yuvalsw)


-- commits line at r1:

Previously, yuvalsw wrote…

move to starkware-development. Is it on top of main on purpose?

I just forgot to change the base in git, sorry.

@Stavbe Stavbe force-pushed the stav/disable_trace_padding_for_prover_input_info branch from e35610c to 5b37adc Compare April 14, 2025 07:38
@Stavbe Stavbe force-pushed the stav/disable_trace_padding_for_prover_input_info branch from 5b37adc to 3179708 Compare April 14, 2025 10:35
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (b9330cd) to head (3179708).
Report is 2 commits behind head on starkware-development.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           starkware-development    #2066   +/-   ##
======================================================
  Coverage                  96.53%   96.53%           
======================================================
  Files                        102      102           
  Lines                      43096    43096           
======================================================
  Hits                       41603    41603           
  Misses                      1493     1493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DavidLevitGurevich)

@Stavbe Stavbe merged commit ba51705 into starkware-development Apr 14, 2025
92 of 93 checks passed
@Stavbe Stavbe deleted the stav/disable_trace_padding_for_prover_input_info branch April 14, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants