-
Notifications
You must be signed in to change notification settings - Fork 187
Stav/disable trace padding for prover input info #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stav/disable trace padding for prover input info #2066
Conversation
|
Benchmark Results for unmodified programs 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich)
-- commits
line 0 at r1:
move to starkware-development. Is it on top of main on purpose?
Hi, @Stavbe, should this PR target main? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich and @yuvalsw)
Previously, yuvalsw wrote…
move to starkware-development. Is it on top of main on purpose?
I just forgot to change the base in git, sorry.
e35610c
to
5b37adc
Compare
5b37adc
to
3179708
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## starkware-development #2066 +/- ##
======================================================
Coverage 96.53% 96.53%
======================================================
Files 102 102
Lines 43096 43096
======================================================
Hits 41603 41603
Misses 1493 1493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @DavidLevitGurevich)
Set disable trace padding flag if prover input info is required.
Note that this flag only affects in proof mode.
This change is