Skip to content

CI: run main workflows also on starkware-development branch #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Mar 25, 2025

CI: run main workflows also on starkware-development branch

Updates the CI workflows so that main workflows are also executed on the starkware-development branch.

Note: The hyper_threading_benchmark workflow will be compared against main, and not against starkware-development.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@JulianGCalderon JulianGCalderon marked this pull request as ready for review March 25, 2025 15:10
@JulianGCalderon JulianGCalderon added the pipelines This PR/issue is exclusively about improving our CI label Mar 25, 2025
@FrancoGiachetta
Copy link
Contributor

Since this branch will eventually be synced with main, shouldn't the changelog workflow also be included?

Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.299 s ±  0.057 s    [User: 25.521 s, System: 0.775 s]
  Range (min … max):   26.259 s … 26.339 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.321 s ±  0.077 s    [User: 25.595 s, System: 0.725 s]
  Range (min … max):   26.266 s … 26.375 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.591 s ±  0.006 s    [User: 25.609 s, System: 0.752 s]
  Range (min … max):   14.587 s … 14.595 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.600 s ±  0.004 s    [User: 25.599 s, System: 0.777 s]
  Range (min … max):   14.597 s … 14.603 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.575 s ±  0.425 s    [User: 37.514 s, System: 0.924 s]
  Range (min … max):   10.275 s … 10.876 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.893 s ±  0.104 s    [User: 37.587 s, System: 0.939 s]
  Range (min … max):   10.820 s … 10.967 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.03 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.408 s ±  0.003 s    [User: 38.255 s, System: 0.946 s]
  Range (min … max):   10.405 s … 10.410 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.345 s ±  0.114 s    [User: 38.063 s, System: 0.937 s]
  Range (min … max):   10.264 s … 10.425 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.411 s ±  0.108 s    [User: 38.264 s, System: 0.971 s]
  Range (min … max):   10.334 s … 10.487 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.341 s ±  0.121 s    [User: 38.200 s, System: 0.936 s]
  Range (min … max):   10.255 s … 10.426 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.260 s ±  0.076 s    [User: 38.479 s, System: 1.045 s]
  Range (min … max):   10.207 s … 10.314 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.425 s ±  0.166 s    [User: 38.378 s, System: 1.115 s]
  Range (min … max):   10.308 s … 10.542 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 16


Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.138 ± 0.014 2.121 2.166 1.00 ± 0.01
head big_factorial 2.132 ± 0.006 2.124 2.143 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.061 ± 0.010 2.042 2.071 1.01 ± 0.02
head big_fibonacci 2.050 ± 0.029 2.024 2.104 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.590 ± 0.121 7.451 7.816 1.00 ± 0.02
head blake2s_integration_benchmark 7.587 ± 0.039 7.540 7.668 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.200 ± 0.020 2.178 2.242 1.00 ± 0.01
head compare_arrays_200000 2.198 ± 0.026 2.180 2.269 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.451 ± 0.009 1.444 1.472 1.00
head dict_integration_benchmark 1.460 ± 0.015 1.442 1.489 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.223 ± 0.005 1.215 1.231 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.218 ± 0.006 1.212 1.233 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.679 ± 0.109 7.585 7.973 1.00 ± 0.02
head integration_builtins 7.643 ± 0.058 7.557 7.761 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.896 ± 0.027 7.855 7.938 1.00 ± 0.01
head keccak_integration_benchmark 7.893 ± 0.029 7.830 7.923 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.173 ± 0.018 2.155 2.214 1.00 ± 0.01
head linear_search 2.171 ± 0.024 2.152 2.238 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.549 ± 0.018 1.529 1.584 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.536 ± 0.017 1.521 1.580 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.496 ± 0.013 1.484 1.530 1.01 ± 0.01
head math_integration_benchmark 1.488 ± 0.015 1.472 1.524 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.228 ± 0.008 1.221 1.243 1.00
head memory_integration_benchmark 1.232 ± 0.019 1.219 1.283 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.602 ± 0.011 1.590 1.621 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.595 ± 0.010 1.584 1.612 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 533.8 ± 2.1 531.8 539.4 1.00
head pedersen 533.9 ± 1.9 532.0 538.0 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 637.9 ± 3.7 632.9 645.0 1.00
head poseidon_integration_benchmark 639.5 ± 6.8 633.3 653.7 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.868 ± 0.009 1.859 1.884 1.01 ± 0.01
head secp_integration_benchmark 1.858 ± 0.007 1.850 1.874 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 633.9 ± 5.8 627.2 646.7 1.01 ± 0.01
head set_integration_benchmark 629.3 ± 1.8 627.0 632.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.223 ± 0.018 4.193 4.247 1.00 ± 0.01
head uint256_integration_benchmark 4.207 ± 0.039 4.169 4.306 1.00

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (3aed532) to head (6bbd507).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2025   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         102      102           
  Lines       42720    42720           
=======================================
  Hits        41241    41241           
  Misses       1479     1479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JulianGCalderon JulianGCalderon added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 957f7f1 Mar 25, 2025
93 of 96 checks passed
@JulianGCalderon JulianGCalderon deleted the update-ci-for-starknet-development branch March 25, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants