-
Notifications
You must be signed in to change notification settings - Fork 187
Stav/use btmap #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stav/use btmap #2023
Conversation
|
Benchmark Results for unmodified programs 🚀
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 102 102
Lines 42755 42755
=======================================
Hits 41276 41276
Misses 1479 1479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fb8fa9b
to
21bbb35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @FrancoGiachetta, @JulianGCalderon, and @yuvalsw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @FrancoGiachetta and @JulianGCalderon)
845e3e0
to
b2a9287
Compare
CHANGELOG.md
Outdated
* fix: Updated the logic for collecting builtin segment data for prover input info, removing dependency on the existence of stop pointers. [#2022](https://github.com/lambdaclass/cairo-vm/pull/2022) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is repeated. Please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
130c1dc
to
9ce2f47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich and @JulianGCalderon)
CHANGELOG.md
Outdated
* fix: Updated the logic for collecting builtin segment data for prover input info, removing dependency on the existence of stop pointers. [#2022](https://github.com/lambdaclass/cairo-vm/pull/2022) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
15a1f92
to
d413702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JulianGCalderon, you are blocking&approve
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich and @JulianGCalderon)
I think that issue is related to reviewable. It shouldn't be a problem as from Github's point of view, I approved the PR. |
@Stavbe there are some Ci jobs failing. Could you fix them please? |
Use Btreemap instead of hashmap
Description
For deterministic iteration order in the adapter side.
Checklist
This change is