-
Notifications
You must be signed in to change notification settings - Fork 187
Add Commit Signing section #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Benchmark Results for unmodified programs 🚀
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 102 102
Lines 42726 42726
=======================================
Hits 41247 41247
Misses 1479 1479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Julian Gonzalez Calderon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]>
* Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]>
We added the requirement that all commits for all PRs to this repo must be signed. This PR adds a section in the
CONTRIBUTING
file explaining this requirement.