Skip to content

KEP-4601: Graduate authorize with selector to stable #5326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 21, 2025

  • One-line PR description: Graduate KEP-4601 to stable
  • Other comments: No changes since beta in 1.32

/sig auth

/cc @deads2k
for sig-auth

/cc @wojtek-t
for PRR

@k8s-ci-robot k8s-ci-robot requested review from deads2k and wojtek-t May 21, 2025 15:36
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2025
@deads2k
Copy link
Contributor

deads2k commented May 21, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2025
@enj enj added this to SIG Auth May 22, 2025
@enj enj moved this to Needs Triage in SIG Auth May 22, 2025
@aramase aramase moved this from Needs Triage to In Review in SIG Auth Jun 2, 2025
@@ -3,3 +3,5 @@ alpha:
approver: "@wojtek-t"
beta:
approver: "@wojtek-t"
stable:
approver: "@wojtek-t"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpbetz signed up to take this one (I'm pairing / shadowing)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're generally not trying to switch in the middle of lifecycle.

@@ -42,4 +42,5 @@ disable-supported: true

# The following PRR answers are required at beta release
metrics:
- find-metric-for-failed-authorization
Copy link
Member

@BenTheElder BenTheElder Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this name was never actually used? So we're just updating the metadata here, not renaming/removing anything?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my understanding too

@wojtek-t wojtek-t self-assigned this Jun 3, 2025
@wojtek-t
Copy link
Member

wojtek-t commented Jun 3, 2025

/approve PRR

/hold
for the remaining comment - feel free to hold cancel

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

5 participants