feat(ws): Introduce drawer to workspace creation wizard #310
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thaorell
force-pushed
the
notebooks-v2-workspace-creation-ui-enhancements
branch
from
4cc7471 to
9b27b1a
Compare
thaorell
changed the title
Signed-off-by: Charles Thao <[email protected]>
thaorell
force-pushed
the
notebooks-v2-workspace-creation-ui-enhancements
branch
from
9b27b1a to
9fcb9a2
Compare
Signed-off-by: Charles Thao <[email protected]>
|
@jenny-s51 please review |
|
/ok-to-test |
There was a problem hiding this comment.
Awesome work on this @thaorell ! The functionality of the drawer is looking really solid and this is a great addition.
Can we implement the drawer to utilize the full height of the content area? It's not rendering at full height at the moment.
It should take the full height of the page container, similar to the drawer in the workspaces list view:
| const onExpand = () => { | ||
| if (drawerRef.current) { | ||
| drawerRef.current.focus(); | ||
| } | ||
| }; | ||
|
|
||
| const onClick = (podConfig?: WorkspacePodConfig) => { | ||
| setIsExpanded(true); | ||
| onSelect(podConfig); | ||
| }; | ||
|
|
||
| const onCloseClick = () => { | ||
| setIsExpanded(false); | ||
| }; |
There was a problem hiding this comment.
Can we memoize these @thaorell ?
closes: #249
screencast-localhost_9000-2025_05_06-10_45_22.webm