Improve speed and cancel behaviour #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two changes:
OKHTTPClient.extractNextJSON():By "consuming" the whitespaces and newlines before and after a JSON token, the parsing speed has been improved a lot for long running responses. Previously each extracted JSON left back some whitespaces which had to be skipped again within the buffer.
In my tests (with a response consisting of 878 tokens sent from a "fake Ollama server", the reception of the whole response went from 7.9s to 2.3s!
OKHTTPClient.stream():The Combine based
stream()method did not cancel the data task when the stream was cancelled. This could be observed when an Ollamac user pushed the cancel button, but generation still continued in the background.