POC: Make assignment expressions and function calls safe #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents unsafe operations since mutable covariant arrays can no longer be assigned to their contravariant.
This refactored
isRelatedTo
and similar functions to accept an options object which made feeding the current node,errorNode
, down torecursiveTypeRelatedTo
before computingvariances
to override the default variance for type parameters which is nowinvariant
to becovariant
for array literals only.It also updates
getRelationKey
to also take anerrorNode
which is used to differentiate the relation key when the source is an array literal. This allowsisTypeRelatedTo
to return different results depending on whether an array literal or a non-literal array with the same type are the source.TODO:
Test Plan:
foo.ts: