Skip to content
This repository was archived by the owner on Feb 12, 2021. It is now read-only.

Implement gridstack min/max item dimension #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Zacaria
Copy link

@Zacaria Zacaria commented May 25, 2016

Hi ! I found a big help in implementing your library.

I propose you to add better implementation of gridstack.js capabilities.

The new options for a widget are :

  • minWidth : applied with gs-item-min-width attribute
  • minHeight : applied with gs-item-min-height attribute
  • maxWidth : applied with gs-item-max-width attribute
  • maxHeight : applied with gs-item-max-height attribute

I let you generate the dist file :)

btw : it's my first PR so I don't know which information you would need

@kdietrich
Copy link
Owner

Hi @Zacaria,

thank you for your PR. 👍 Could you please fix the indentations so that we can see better which lines have changed? See: https://github.com/kdietrich/gridstack-angular/pull/8/files Thanks!

@Zacaria
Copy link
Author

Zacaria commented May 27, 2016

Would you please tell me the name of the linter/formatter you are using ?

@kdietrich
Copy link
Owner

@Zacaria I've added jscs. Could you resubmit your PR? Thanks!

@siecj
Copy link

siecj commented Jun 30, 2017

Hi, @Zacaria @kdietrich

I think there is no need to watch the "data-gs-min-height", "data-gs-min-width", "data-gs-max-height", "data-gs-max-width" in gridstackitem.directive.js. These four properties can't be changed by user.

PS: It is still very hard to see the changed part because of the indentation...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants