Skip to content

GitHub Action to discover typos with codespell #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2022
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 27, 2022

https://pypi.org/project/codespell

Test results: https://github.com/cclauss/jython.github.io/actions

2
./jython.github.io/registry.md:7: envrionment ==> environment
./jython.github.io/registry.md:11: formated ==> formatted

cclauss added 4 commits May 27, 2022 12:41
https://pypi.org/project/codespell
```
2
./jython.github.io/registry.md:7: envrionment ==> environment
./jython.github.io/registry.md:11: formated ==> formatted
```
Copy link

@IMperiumX IMperiumX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspiring, i'll Start every project of mine with that action in it...

@jeff5
Copy link
Member

jeff5 commented May 28, 2022

Seems reasonable to me. Thanks.

@jeff5 jeff5 merged commit 72f156f into jython:master May 28, 2022
@cclauss cclauss deleted the patch-2 branch May 28, 2022 15:52
@jeff5
Copy link
Member

jeff5 commented May 28, 2022

@cclauss : I expected this to run when merged, but it didn't. Am I missing something?

@cclauss
Copy link
Contributor Author

cclauss commented May 28, 2022

@jeff5
Copy link
Member

jeff5 commented May 29, 2022

If it runs on subsequent pushes and PRs, that's fine. I was obviously wrong to expect it to run on the commit that adds it.

codespell takes the interesting approach of trying to catalogue misspellings, rather than using a dictionary of correctly spelled words. If not 100% successful, it makes a change for the errors to be mostly in the other direction (not constantly complaining about English spellings or words it doesn't know).

I'll also look at jython/jython#179.

@cclauss
Copy link
Contributor Author

cclauss commented May 29, 2022

Codespell is good at off-by-one typos like one missing letter or two transposed letters but it is certainly not a full spellchecker. The upside is that it is astoundingly fast even on a massive repo of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants