Minor fixes and adjustments #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See GitPython issue jupyter#637.
Remove some old unused code, add some docstrings, and do some linting.
diff_format was getting hard to navigate due to its size and many functions. This extracts some of the funtionality into a separate file diff_utils. The guiding principle is supposed to be a separation of concerns, where functions that construct/verify diff entries are in the diff_format file, and everything else goes into utils.
Should be called in LoggingAction when parsing arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with one of the dependencies of nbdime (gitpython-developers/GitPython#637), which this PR fixes. It also includes a split of the
diff_formatfile, as it was getting rather unwieldy.