-
-
Notifications
You must be signed in to change notification settings - Fork 276
[FIXED] : Docs Navigation Bar in the mobile dimensions #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[FIXED] : Docs Navigation Bar in the mobile dimensions #1518
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 448 448
Branches 116 116
=========================================
Hits 448 448 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@DhairyaMajmudar Review this PR. |
@Yashwanth1906 fix this |
@DhairyaMajmudar Fixed this issue . |
@benjagm @DhairyaMajmudar Is there anything i need to change? |
@Yashwanth1906 Thank you for your patience, I'll review this tomorrow EOD. |
@DarhkVoyd okay. |
pages/index.page.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn’t find any discussion about these changes in the linked issue, but they do appear to be better. However, the buttons are inconsistent in their responsive width compared to the buttons of other neighboring card buttons. Team's decision.
@DarhkVoyd Im done with all the changes you asked for. Let me know if everything is fine |
@DarhkVoyd @DhairyaMajmudar Can u review this pr? |
@idanidan29 can you please help me reviewing this PR? |
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
@benjagm @idanidan29 What is this check ? How can i resolve it? |
All good. That check is the PR body validation. Nothing to worry about. |
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
After:
Screen.Recording.2025-03-14.191538.mp4
If relevant, did you update the documentation?
N/A.
Summary
Does this PR introduce a breaking change?
No