testscripts: python tests for numpy and psycopg2 #2214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
approved these changes
Aug 1, 2024
testscripts/ld/numpy/devbox.json
Outdated
| "python -m venv $VENV_DIR", | ||
| ], | ||
| "scripts": { | ||
| "test": [ |
There was a problem hiding this comment.
for these to run automatically theyneed to be called run_test. Maybe want to call it run_test_disabled ? Or add an env var so it exits 0 by default if env var is not set
devbox.json
Outdated
| @@ -39,6 +39,11 @@ | |||
| "test-projects-only": "DEVBOX_RUN_PROJECT_TESTS=1 go test -v -timeout ${DEVBOX_GOLANG_TEST_TIMEOUT:-30m} ./... -run \"TestExamples|TestScriptsWithProjects\"", | |||
| "update-examples": "devbox run build && go run testscripts/testrunner/updater/main.go", | |||
| "tidy": "go mod tidy", | |||
|
|
|||
| "test-linux-amd64": [ | |||
There was a problem hiding this comment.
it feels a bit weird to have this in the top level devbox.json, maybe we add a devbox.json to testscripts? It could call out to this devbox in order to build the linux devbox
not a blocker
Add tests that install Python with Devbox and then run scripts that import numpy and psycopg2. They currently fail on Linux due to linker errors. To run the tests on Linux with Docker, run: devbox run -e DEVBOX_RUN_FAILING_TESTS=1 docker-testscripts -test.run '^TestScripts$/python' The new docker-testscripts script in devbox.json runs testscripts in a Docker container to make it easier to test various Linux distros and architectures.
gcurtis
force-pushed
the
gcurtis/ldtests
branch
from
50d3a91 to
6eb1d1c
Compare
gcurtis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests that install Python with Devbox and then run scripts that import numpy
and psycopg2. They currently fail on Linux due to linker errors related to missing shared libraries.
To run the tests on Linux with Docker, run:
The new docker-testscripts script in devbox.json runs testscripts in a Docker
container to make it easier to test various Linux distros and architectures.