chore: reduce reliance on esModuleInterop #8842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeysal
approved these changes
Aug 17, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order for our own types to be as consumable as possible, we should avoid relying on
esModuleInterop(as that will force our consumers to also use that flag). This PR removes about 2/3 of our usage of it. Removing all will be a breaking change since it will removeexport =, which means we must either use default or named exports. Also, we have to update some upstream libraries that only support node 8 so that they work without it. So at least one more PR will come when we drop node 6 and bump some libs. But this is a good startDefinitelyTyped/DefinitelyTyped#33705 (comment)
Test plan
Green CI as this just changes how we import modules