Proxy support for browserstack plugin #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 2, 2020 11:53
…plugin has proxy setup
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/common/tracking/PluginsTracker.java
Outdated
Show resolved
Hide resolved
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/common/tracking/PluginsTracker.java
Outdated
Show resolved
Hide resolved
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/common/tracking/PluginsTracker.java
Outdated
Show resolved
Hide resolved
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/common/tracking/PluginsTracker.java
Outdated
Show resolved
Hide resolved
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/common/tracking/PluginsTracker.java
Outdated
Show resolved
Hide resolved
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/common/tracking/PluginsTracker.java
Outdated
Show resolved
Hide resolved
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/common/proxysettings/JenkinsProxySettings.java
Show resolved
Hide resolved
added 2 commits
November 6, 2020 17:27
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/automate/ci/jenkins/AutomateTestAction.java
Outdated
Show resolved
Hide resolved
rchougule
reviewed
Nov 6, 2020
Comment on lines
24
to
25
| String proxyHost = jenkinsProxy.name; | ||
| int proxyPort = jenkinsProxy.port; |
rchougule
reviewed
Nov 6, 2020
Comment on lines
72
to
73
| String username = JenkinsProxySettings.getUsername(); | ||
| String password = JenkinsProxySettings.getPassword(); |
There was a problem hiding this comment.
final .... consider final as const of JS. or any value which won't be re-assigned further...
Archish27
reviewed
Nov 9, 2020
|
|
||
| public class JenkinsProxySettings { | ||
|
|
||
| static final ProxyConfiguration jenkinsProxy = Jenkins.getInstanceOrNull() != null ? Jenkins.getInstanceOrNull().proxy : null; |
There was a problem hiding this comment.
Suggested change
| static final ProxyConfiguration jenkinsProxy = Jenkins.getInstanceOrNull() != null ? Jenkins.getInstanceOrNull().proxy : null; | |
| private static final ProxyConfiguration jenkinsProxy = Jenkins.getInstanceOrNull() != null ? Jenkins.getInstanceOrNull().proxy : null; |
Please define correct accessSpecifiers wherever necessary.
yashLadha
approved these changes
Nov 11, 2020
francisf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELATED PR
https://github.com/browserstack/automate-client-java/pull/5/files
Jenkins plugin work behind proxy support (Automate client java changes)