Skip to content

Expose incr/decr default and time protocol arguments in client class #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions bmemcached/client/distributed.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,21 +204,25 @@ def cas(self, key, value, cas, time=0, compress_level=-1):
server = self._get_server(key)
return server.cas(key, value, cas, time, compress_level)

def incr(self, key, value):
def incr(self, key, value, default=0, time=1000000):
"""
Increment a key, if it exists, returns it's actual value, if it don't, return 0.

:param key: Key's name
:type key: six.string_types
:param value: Number to be incremented
:type value: int
:param default: If key not set, initialize to this value
:type default: int
:param time: Time in seconds that your key will expire.
:type time: int
:return: Actual value of the key on server
:rtype: int
"""
server = self._get_server(key)
return server.incr(key, value)
return server.incr(key, value, default=default, time=time)

def decr(self, key, value):
def decr(self, key, value, default=0, time=1000000):
"""
Decrement a key, if it exists, returns it's actual value, if it don't, return 0.
Minimum value of decrement return is 0.
Expand All @@ -227,8 +231,12 @@ def decr(self, key, value):
:type key: six.string_types
:param value: Number to be decremented
:type value: int
:param default: If key not set, initialize to this value
:type default: int
:param time: Time in seconds that your key will expire.
:type time: int
:return: Actual value of the key on server
:rtype: int
"""
server = self._get_server(key)
return server.decr(key, value)
return server.decr(key, value, default=default, time=time)
16 changes: 12 additions & 4 deletions bmemcached/client/replicating.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,24 +232,28 @@ def delete_multi(self, keys):

return all(returns)

def incr(self, key, value):
def incr(self, key, value, default=0, time=1000000):
"""
Increment a key, if it exists, returns it's actual value, if it don't, return 0.

:param key: Key's name
:type key: six.string_types
:param value: Number to be incremented
:type value: int
:param default: If key not set, initialize to this value
:type default: int
:param time: Time in seconds that your key will expire.
:type time: int
:return: Actual value of the key on server
:rtype: int
"""
returns = []
for server in self.servers:
returns.append(server.incr(key, value))
returns.append(server.incr(key, value, default=default, time=time))

return returns[0]

def decr(self, key, value):
def decr(self, key, value, default=0, time=1000000):
"""
Decrement a key, if it exists, returns it's actual value, if it don't, return 0.
Minimum value of decrement return is 0.
Expand All @@ -258,11 +262,15 @@ def decr(self, key, value):
:type key: six.string_types
:param value: Number to be decremented
:type value: int
:param default: If key not set, initialize to this value
:type default: int
:param time: Time in seconds that your key will expire.
:type time: int
:return: Actual value of the key on server
:rtype: int
"""
returns = []
for server in self.servers:
returns.append(server.decr(key, value))
returns.append(server.decr(key, value, default=default, time=time))

return returns[0]
8 changes: 8 additions & 0 deletions test/test_simple_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,18 @@ def testIncrement(self):
self.assertEqual(0, self.client.incr('test_key', 1))
self.assertEqual(1, self.client.incr('test_key', 1))

def testIncrementInitialize(self):
self.assertEqual(10, self.client.incr('test_key', 1, default=10))
self.assertEqual(11, self.client.incr('test_key', 1, default=10))

def testDecrement(self):
self.assertEqual(0, self.client.decr('test_key', 1))
self.assertEqual(0, self.client.decr('test_key', 1))

def testDecrementInitialize(self):
self.assertEqual(10, self.client.decr('test_key', 1, default=10))
self.assertEqual(9, self.client.decr('test_key', 1, default=10))

def testFlush(self):
self.client.set('test_key', 'test')
self.assertTrue(self.client.flush_all())
Expand Down