-
Notifications
You must be signed in to change notification settings - Fork 58
Add TLS support for TCP sockets #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bf79e97
Add TLS support for TCP sockets
moisesguimaraes f2cbe39
Add test certificates
moisesguimaraes 1f2b599
Add TLS tests
moisesguimaraes 47372d4
Skip TLS tests when TLS memcached is not available
moisesguimaraes c45d689
Uses trustme instead of hardcoded certificates.
moisesguimaraes f086033
Add doc notes about TLS context.
moisesguimaraes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ pytest-cov==2.7.1 | |
mock==2.0.0 | ||
flake8==3.7.7 | ||
bumpversion==0.5.3 | ||
trustme==0.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
import os | ||
import pytest | ||
import subprocess | ||
import ssl | ||
import time | ||
import trustme | ||
|
||
import bmemcached | ||
import test_simple_functions | ||
|
||
|
||
ca = trustme.CA() | ||
server_cert = ca.issue_cert(os.environ["MEMCACHED_HOST"] + u"") | ||
|
||
|
||
@pytest.yield_fixture(scope="module", autouse=True) | ||
def memcached_tls(): | ||
key = server_cert.private_key_pem | ||
cert = server_cert.cert_chain_pems[0] | ||
|
||
with cert.tempfile() as c, key.tempfile() as k: | ||
p = subprocess.Popen( | ||
[ | ||
"memcached", | ||
"-p5001", | ||
"-Z", | ||
"-o", | ||
"ssl_key={}".format(k), | ||
"-o", | ||
"ssl_chain_cert={}".format(c), | ||
"-o", | ||
"ssl_verify_mode=1", | ||
], | ||
stdout=subprocess.PIPE, | ||
stderr=subprocess.PIPE, | ||
) | ||
time.sleep(0.1) | ||
|
||
if p.poll() is not None: | ||
pytest.skip("Memcached server is not built with TLS support.") | ||
|
||
yield p | ||
p.kill() | ||
p.wait() | ||
|
||
|
||
class TLSMemcachedTests(test_simple_functions.MemcachedTests): | ||
""" | ||
Same tests as above, just make sure it works with TLS. | ||
""" | ||
|
||
def setUp(self): | ||
ctx = ssl.create_default_context() | ||
|
||
ca.configure_trust(ctx) | ||
|
||
self.server = "{}:5001".format(os.environ["MEMCACHED_HOST"]) | ||
self.client = bmemcached.Client(self.server, tls_context=ctx) | ||
self.reset() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, could you also add some info about in on the
__doc__
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm on vacation now and will be back on this task in the first week of January.