Show CLI errors generated by exp show #4062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
show-exp-show-error
branch
2 times, most recently
from
405bfc7 to
9044141
Compare
mattseddon
force-pushed
the
show-exp-show-error
branch
from
9044141 to
1f3f509
Compare
This was referenced Jun 9, 2023
julieg18
approved these changes
Jun 12, 2023
|
Code Climate has analyzed commit efea638 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (-0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/3
main<- this <- #4075 <- #4077Related to iterative/dvc#9565
This issue was reported on Discord today: https://discord.com/channels/485586884165107732/842220310585147452/1116030033480392836
The user seems to be experiencing a CLI error which means that their experiments appear as if they have no data (technically correct). That means that any attempt to open the experiments webview will result in the setup page being shown.
Now when the CLI throws an error we will let the user open the experiments webview and show an error state. The error state will be shown any time the webview is open and the CLI throws an error. IMO this is more useful than adding an experiments error state to the setup webview (I did originally add both but changed my mind).
Demo
Screen.Recording.2023-06-08.at.1.20.18.pm.mov
Note: A user will still see this if they purposefully go to the setup page when there is a CLI error.
This is an edge case though as I believe the most confusing thing was the redirect to setup when there was an error. If we run into this again then I'll add an error state to the Experiments section of the setup page.