Skip to content

Add zambia config #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jpngfile
Copy link

No description provided.

@jpngfile jpngfile requested a review from aaron-kaplan April 11, 2025 14:02
Copy link
Collaborator

@aaron-kaplan aaron-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently doesn't work, probably because the forecast in /data/aaron/fbf-candidate/original-data/zambia is Riz' version, which uses the wrong season (NDJ). Please fix that, and send a pull request for the forecast configuration in python_maproom_zambia.

Please add a README to /data/aaron/fbf-candidate/original-data/zambia explaining what the different bad years csv files represent, where they came from, and what command was used to convert them to zarr. (@nitinmagima this probably requires input from you.)

@@ -3771,3 +3771,55 @@ countries:
length: 3.0
issue_months: [5, 6, 7, 8]
start_year: 1983
zambia:
logo: Zambia_IRI_120x48.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitinmagima do we have a logo file? If not, we'll use the generic IRI one.

@@ -47,7 +47,7 @@
SERVER.register_error_handler(ClientSideError, pingrid.client_side_error)

month_abbrev = ['jan', 'feb', 'mar', 'apr', 'may', 'jun', 'jul', 'aug', 'sep', 'oct', 'nov', 'dec']
abbrev_to_month0 = dict((abbrev, month0) for month0, abbrev in enumerate(month_abbrev))
abbrev_to_month0: Dict[str, int] = dict((abbrev, month0) for month0, abbrev in enumerate(month_abbrev))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpngfile if you're motivated to set up type checking in Github Actions, I would enthusiastically support that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Before embarking on that, talk to me. Topics to discuss: which type checker, managing the pixi/conda environment.)

sql: select adm0_code as key, adm0_name as label, ST_AsBinary(the_geom) as the_geom
from iridb.g2015_2012_0 where adm0_name = 'Zambia'
vuln_sql: select adm0_code as key, year, sum(vulnerability) as vuln
from public.fbf_vulnerability where adm0_name = 'Zambia' group by 1, 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This presumably doesn't work, because there are no rows for Zambia in the fbf_vulnerability table. That will cease to be a problem once the vulnerability layer is removed, but it would be good to merge this sooner than that. See ethiopia for a dummy query you can use instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants