Skip to content

WTL-852 Add Terraform configuration #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2021
Merged

WTL-852 Add Terraform configuration #22

merged 2 commits into from
Sep 8, 2021

Conversation

apgrucza
Copy link

@apgrucza apgrucza commented Sep 6, 2021

Moving Terraform configuration from the private repository to here

@apgrucza apgrucza changed the title Add Terraform configuration WTL-852 Add Terraform configuration Sep 6, 2021
Copy link

@patrickherrera patrickherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fair bit in there, but it looks good

@@ -0,0 +1,13 @@
module "cloudfront_auth_okta_native" {
source = "github.com/iress/cloudfront-auth//infra/terraform/modules/okta_native"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: double slash in path

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. The double slash syntax is the way to specify a path inside the repo: https://www.terraform.io/docs/language/modules/sources.html#modules-in-package-sub-directories

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I did wonder if it was intentional somehow but couldn't for the life of me figure out what it meant

@apgrucza apgrucza merged commit 912a036 into master Sep 8, 2021
@apgrucza apgrucza deleted the terraform branch September 8, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants