Skip to content

Use access token and dont re-sign using custom keys. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Use access token and dont re-sign using custom keys. #13

merged 1 commit into from
Oct 5, 2020

Conversation

nbshetty
Copy link

@nbshetty nbshetty commented Oct 2, 2020

Includes the initial changes to the OKTA Native Auth.

  • Verify the access_token instead of the id_token.
  • Set the TOKEN cookie with the signed access_token and make it secure http only
  • Removed logic to re-sign the token using custom signing key.

Freaky-namuH
Freaky-namuH approved these changes Oct 4, 2020
View reviewed changes
Copy link

@Freaky-namuH Freaky-namuH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to build a new release?

@nbshetty nbshetty merged commit 1d83d49 into master Oct 5, 2020
@nbshetty nbshetty deleted the use-access-token branch October 6, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freaky-namuH Freaky-namuH Freaky-namuH approved these changes

@apgrucza apgrucza Awaiting requested review from apgrucza

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbshetty @Freaky-namuH