feat(datetime): add hourCycle property #23686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: angular
EinfachHans
changed the title
liamdebeasi
requested review from
willmartian and
liamdebeasi
and removed request for
willmartian
liamdebeasi
suggested changes
Jul 26, 2021
There was a problem hiding this comment.
Thanks for working on this! This is a great start. I would like to see this PR move more in line with what the JavaScript internationalization APIs use so that the API is more future proof. I left changes below which are required to merge this PR.
Please let me know if you have any questions about anything I wrote.
|
Requested Changes pushed, i think if you want to have some specific docs and explanation here it would be easier if you directly push into this pr or give me the text as i'm not the best in writing understandable docs in english 😃 |
EinfachHans
changed the title
willmartian
approved these changes
Jul 26, 2021
liamdebeasi
changed the title
|
Merged. Thank you!! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #23661
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently the date-time uses the locale to check if it should use a 12 or 24 hour format
Issue Number: #23661
What is the new behavior?
timeFormatprop added which could be '12h' or '24h' (or undefined)Does this introduce a breaking change?
Other information