Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.
This repository was archived by the owner on May 1, 2020. It is now read-only.

Fix Template In-lining to account for multiple components in same file #729

Open
@danbucholtz

Description

@danbucholtz

^ 😸. At least 2x per week I hear of developers running into this.

Presently, we inline templates by converting the templateUrl into template string in the component decorator. This works very well when there is one component per file. There are issues with the current approach when there are two or more components in the same file. We're looking to improve this - it just hasn't been the highest priority item for us.

See the source code here and the tests here. Basically we need to improve the regex to detect the correct component.

Please let me know if you're interested in helping.

Thanks,
Dan

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions