Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.
This repository was archived by the owner on May 1, 2020. It is now read-only.

Exclude node_modules folder from tslint #1203

Open
@datencia

Description

@datencia

Short description of the problem:

After upgrade to Ionic 3, tslint shows errors even for external typescript libraries inside the node_modules folder.

What behavior are you expecting?

tslint should lint files under src folder only.

Steps to reproduce:

  1. create an empty ionic project

    $ ionic start demo-app blank
  2. install a dependency which includes the typescript files (e.g. ng2-dynamic-forms/core)

    $ npm install @ng2-dynamic-forms/core
  3. import the module into the app module (modify the app.module.ts as follows):

    ...
    import { DynamicFormsCoreModule } from '@ng2-dynamic-forms/core';
    
    @NgModule({
      declarations: [
        MyApp,
        HomePage
      ],
      imports: [
        BrowserModule,
        DynamicFormsCoreModule.forRoot(),
        IonicModule.forRoot(MyApp)
      ],
      ...
    
  4. run the linter

    $ npm run lint

image

Which @ionic/app-scripts version are you using?

2.1.4

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

related issues: #482 & #161

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions