Skip to content

Update CratesIoApi.kt #6691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Update CratesIoApi.kt #6691

merged 1 commit into from
Jan 25, 2021

Conversation

Pzixel
Copy link
Contributor

@Pzixel Pzixel commented Jan 18, 2021

Fixes issues with irrelevant search results due to empty $sort: https://github.com/rust-lang/crates.io/blob/master/src/controllers/krate/search.rs#L65

Fore more details see rust-lang/crates.io#3187

Ideally plugin should narrow the search results even further using startsWith on crates.io response since not all of the results are really relevant.

@vlad20012
Copy link
Member

Hello! Thanks for the PR!
I see you're a first-time contributor. Could you, please, sign our Contributor License Agreement as mentioned in CONTRIBUTING.md, and add your username to CONTRIBUTORS.txt?

@Pzixel
Copy link
Contributor Author

Pzixel commented Jan 18, 2021

I've signed the CLA

@vlad20012
Copy link
Member

👍
bors r+

@bors
Copy link
Contributor

bors bot commented Jan 25, 2021

Build succeeded:

@bors bors bot merged commit c611646 into intellij-rust:master Jan 25, 2021
@github-actions github-actions bot added this to the v140 milestone Jan 25, 2021
@Undin Undin added the fix Pull requests that fix some bug(s) label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants