T: Don't unescape test output #5949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchernyavsky
force-pushed
the
fix-escape-test-out
branch
from
7117799 to
45c7d58
Compare
Undin
reviewed
Aug 26, 2020
There was a problem hiding this comment.
@mchernyavsky Do I understand correctly that we can't distinguish \ as general symbol (for example, as path separator on Windows) and as escape symbol in Cargo messages?
Undin
approved these changes
Aug 28, 2020
src/test/kotlin/org/rustSlowTests/cargo/runconfig/test/CargoTestNodeInfoTest.kt
Show resolved
Hide resolved
mchernyavsky
force-pushed
the
fix-escape-test-out
branch
6 times, most recently
from
91e857f to
61f21f7
Compare
Undin
approved these changes
Aug 31, 2020
src/test/kotlin/org/rustSlowTests/cargo/runconfig/test/CargoTestNodeInfoTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/rustSlowTests/cargo/runconfig/test/CargoTestNodeInfoTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/rustSlowTests/cargo/runconfig/test/CargoTestNodeInfoTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/test/CargoTestEventsConverter.kt
Show resolved
Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/test/CargoTestEventsConverter.kt
Outdated
Show resolved
Hide resolved
mchernyavsky
force-pushed
the
fix-escape-test-out
branch
from
61f21f7 to
78ff7f8
Compare
|
Canceled. |
mchernyavsky
force-pushed
the
fix-escape-test-out
branch
from
78ff7f8 to
0d6b654
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5768.
Fixes #5703.
Fixes #5974.
Fixes #5985.