[UR] Partially reapply "Move conformance tests over to lit" (#18382) #18392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to old MR: #17998 |
sarnex
approved these changes
May 9, 2025
| @@ -184,7 +183,8 @@ jobs: | |||
| - name: Test adapters | |||
| env: | |||
| ZE_ENABLE_LOADER_DEBUG_TRACE: 1 | |||
| run: env UR_CTS_ADAPTER_PLATFORM="${{matrix.adapter.platform}}" ctest -C ${{matrix.build_type}} --test-dir build --output-on-failure -L "conformance" --timeout 600 -VV | |||
| LIT_OPTS: " --timeout 120" | |||
There was a problem hiding this comment.
nit: is there a whitespace issue here or is it just github diff?
There was a problem hiding this comment.
Looks valid to me, but there is a bit of possibly-unneeded whitespace before --timeout.
RossBrunton
force-pushed
the
ross/conflitfix
branch
from
a3b6bfe to
b198a3c
Compare
) This reverts commit 44ed9b7, but excludes the problematic changes to jobs.
RossBrunton
force-pushed
the
ross/conflitfix
branch
from
b198a3c to
e185000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 44ed9b7, but
excludes the problematic changes to jobs.