Workaround possible TH environment overflow running wine
#1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still do not understand the cause, but wine seems to fail to start (we get a segfault) when building `cardano-wallet-cli` test `unit`. It seems to be an overflow somewhere in bash or very early in the `wine` startup code (since nothing is logged even with `WINEDEBUG=+all`). This changes `unsets` the large `pkgsHostTargetAsString` environment variable before wine is started (after that variable has been used). This seems to be enough to avoid the issue though it is worrying that it is not clear why.
|
bors try |
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still do not understand the cause, but wine seems to fail to start (we get a segfault) when building
cardano-wallet-clitestunit. It seems to be an overflow somewhere in bash or very early in thewinestartup code (since nothing is logged even withWINEDEBUG=+all).This changes
unsetsthe largepkgsHostTargetAsStringenvironment variable before wine is started (after that variable has been used). This seems to be enough to avoid the issue though it is worrying that it is not clear why.