[Fix] Ignore hashbang and BOM while parsing #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint does this outside their espree parser, so we need to do it as well. Just like ESLint, the code will convert hashbang to comments and strip off the BOM completely before handing the content to the parser.
Codecov Report
@@ Coverage Diff @@
## main #2431 +/- ##
=======================================
Coverage 95.18% 95.19%
=======================================
Files 66 66
Lines 2783 2787 +4
Branches 935 936 +1
=======================================
+ Hits 2649 2653 +4
Misses 134 134
Continue to review full report at Codecov.
|
silverwind
force-pushed
the
hashbang-bom
branch
from
93f7a98 to
d8da3f3
Compare
silverwind
changed the title
silverwind
force-pushed
the
hashbang-bom
branch
2 times, most recently
from
646e864 to
d0367fa
Compare
|
Rebased and split up into 4 separate tests (all variants of bom,hashbang and one test without any of them). |
ljharb
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint does this outside their espree parser, so we need to do it as well. Just like ESLint, the code will convert hashbang to comments and strip off the BOM completely before handing the content to the parser.
Fixes: #1369