Skip to content

Add warning about async Webpack configs #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2021
Merged

Add warning about async Webpack configs #1962

merged 1 commit into from
Jan 30, 2021

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Dec 10, 2020 •
edited
Loading

See discussion in #1961

@coveralls
Copy link

coveralls commented Dec 10, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.87% when pulling 877e22c on ogonkov:patch-1 into 9fa6bc9 on benmosher:master.

ljharb
ljharb reviewed Dec 10, 2020
View reviewed changes
@ogonkov ogonkov marked this pull request as ready for review December 11, 2020 19:50
@ogonkov ogonkov requested a review from ljharb December 11, 2020 21:59
@ogonkov
Copy link
Contributor Author

ogonkov commented Jan 14, 2021

@ljharb can you look to this PR please?

ljharb
ljharb approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great

@ljharb ljharb merged commit 877e22c into import-js:master Jan 30, 2021
@ogonkov ogonkov deleted the patch-1 branch February 6, 2021 13:15
@jet2jet jet2jet mentioned this pull request Apr 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
package: resolver/webpack
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogonkov @coveralls @ljharb