Skip to content

[SDK-3266] fix Gree webview clash #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

andrew-yangy
Copy link
Collaborator

@andrew-yangy andrew-yangy commented Sep 19, 2024

Summary

There is an issue with using both gree webview plugin and our unity sdk, as we are using the same assembly and package name as the original gree webview package.

We need to rename the webview reference in our sdk to solve the clash.

  • rename unity-webview.asmdef and change the name from unity-webview to Immutable.Browser.Gree
  • change the target from Webview to ImmutableWebview in XCode
  • update info.plist
  • run ./install.sh, Build Succeeded but gets cp: *.bundle.meta: No such file or directory
  • Manually rename /iOS/Webview.mm to /iOS/ImmutableWebview.mm

Customer Impact

Added

Changed

Deprecated

Removed

Fixed

Security

Things worth calling out

Other things to consider:

  • Sample app is updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Sample game is updated with new SDK changes
  • Replied to GitHub issues

@andrew-yangy andrew-yangy requested a review from a team September 19, 2024 01:42
@andrew-yangy andrew-yangy force-pushed the feature/sdk-3266-name-clash branch from 9c985d8 to c4f5018 Compare September 19, 2024 06:59
@andrew-yangy andrew-yangy merged commit b818af8 into main Sep 20, 2024
15 checks passed
@andrew-yangy andrew-yangy deleted the feature/sdk-3266-name-clash branch September 20, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants