[DX-2757] fix: android custom tabs dismiss callback #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nattb8
force-pushed
the
fix/android-on-dismissed
branch
from
0b82c08 to
7fe8bb1
Compare
nattb8
changed the title
dom-murray
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #177, in some Android devices and newer Android versions, the on-dismiss callback for Chrome Custom Tabs is triggered prematurely before the user is redirected to a game via deep links. This leads to the completion source for PKCE being nullified before the SDK can use it to inform the consumer of the PKCE result.
To solve this, the SDK now detects how Chrome Custom Tabs were dismissed differently.
Customer Impact
Some Android devices and newer Android versions may prevent customers from logging in using the PKCE flow.