[DX-2700] fix: android login and connect pkce not working if minify is enabled in sample app #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattb8
changed the title
nattb8
force-pushed
the
fix/android-proguard
branch
from
5f67a09 to
183b45d
Compare
YermekG
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As pointed out by #172, the
LoginPKCEandConnectImxPKCEfunctions do not work on Android if Minify is enabled. This PR added an example demonstrating how to configure Proguard with Minify enabled in the sample game.Also, fixed the sample application to log out using the appropriate method if the login or connection attempt fails.
Customer Impact
If you enable Minify in your game, please follow the instructions in our documentation here.
Other things to consider: