Skip to content

[DX-2505] feat: login functions #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

[DX-2505] feat: login functions #138

merged 1 commit into from
Dec 13, 2023

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Dec 12, 2023 •
edited
Loading

SDK

  • Added login functions (Login and LoginPKCE)
  • Removed ConnectImxSilent and replaced it with Connect(useCachedSession: true)
  • Updated index.html file (built from ts-immutable-sdk 691ed97)

Sample app
Unauthenticated scene

  • Added login and relogin buttons to the unauthenticated scene
  • Updated ConnectImxSilent to use ConnectImx with useCachedSession set to true instead and added a reconnect button to the unauthenticated scene

Authenticated scene

  • Added a connect button to the authenticated scene for when the user is logged in but not connected
  • Only show IsRegisteredOffchainButton, RegisterOffchainButton, GetAddressButton and ShowTransferButton if the user is connected

@nattb8 nattb8 requested a review from a team December 12, 2023 21:30
@nattb8 nattb8 changed the title feat: login, relogin and reconnect functions feat: login functions Dec 12, 2023
dom-murray
dom-murray previously approved these changes Dec 13, 2023
View reviewed changes
@nattb8 nattb8 merged commit ffb2941 into main Dec 13, 2023
@nattb8 nattb8 deleted the feat/login branch December 13, 2023 03:04
@nattb8 nattb8 changed the title feat: login functions [DX-2505] feat: login functions Dec 13, 2023
@nattb8 nattb8 added the feature label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom-murray dom-murray dom-murray approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattb8 @dom-murray