Skip to content

Make rayon optional #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2016
Merged

Make rayon optional #56

merged 3 commits into from
Nov 18, 2016

Conversation

jackpot51
Copy link
Contributor

This allows compilation on systems that do not currently support rayon or its dependencies, such as Redox

@kaksmet
Copy link
Member

kaksmet commented Nov 16, 2016

Thanks for the pr, it looks good to me.

The travis nightly failure is rust-lang/rust#37786.
I'm gonna push a change allowing nightly to fail on CI.

@kaksmet
Copy link
Member

kaksmet commented Nov 17, 2016

After you add FEATURES="rayon" to the FEATURES matrix in .travis.yml it is ready for merging.

@jackpot51
Copy link
Contributor Author

@kaksmet It should be done now

@kaksmet
Copy link
Member

kaksmet commented Nov 18, 2016

@jackpot51 sorry for not being clear enough. I want travis to test both with and without the rayon feature. For that to happen there should be both an empty FEATURES and one containing "rayon".

This is what I would like the relevant piece of travis.yml to look like:

env:
  - FEATURES=""
  - FEATURES="rayon"

@kaksmet
Copy link
Member

kaksmet commented Nov 18, 2016

Looks good, thanks!

@kaksmet kaksmet merged commit fe8947d into image-rs:master Nov 18, 2016
@jackpot51
Copy link
Contributor Author

Thanks for merging!

wartmanm pushed a commit to wartmanm/jpeg-decoder that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants