Reference implementation of __class_getitem__ and __mro_entries__ #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 82.58%
=========================================
Files ? 1444
Lines ? 359957
Branches ? 0
=========================================
Hits ? 297285
Misses ? 62672
Partials ? 0
Continue to review full report at Codecov.
|
ilevkivskyi
changed the title
ilevkivskyi
changed the title
scoder
reviewed
Sep 10, 2017
| @@ -168,6 +169,25 @@ PyObject_GetItem(PyObject *o, PyObject *key) | |||
| "be integer, not '%.200s'", key); | |||
| } | |||
|
|
|||
| if (PyType_Check(o)) { | |||
| meth = PyObject_GetAttrString(o, "__class_getitem__"); | |||
There was a problem hiding this comment.
This should probably use a Py_IDENTIFIER.
There was a problem hiding this comment.
Yes, when making an actual PR to python/cpython I will probably switch to _PyObject_GetAttrId.
ilevkivskyi
changed the title
ilevkivskyi
force-pushed
the
base-subclass
branch
from
415ad92 to
6f20c45
Compare
…#4667) Changes: * _PyPathConfig_Fini() cannot be called in Py_FinalizeEx(). Py_Initialize() and Py_Finalize() can be called multiple times, but it must not "forget" parameters set by Py_SetProgramName(), Py_SetPath() or Py_SetPythonHome(), whereas _PyPathConfig_Fini() clear all these parameters. * config_get_program_name() and calculate_program_full_path() now also decode paths using Py_DecodeLocale() to use the surrogateescape error handler, rather than decoding using mbstowcs() which is strict. * Change _Py_CheckPython3() prototype: () => (void) * Truncate a few lines which were too long
* Factorize code from PC/getpathp.c and Modules/getpath.c to remove duplicated code * rename pathconfig_clear() to _PyPathConfig_Clear() * Inline _PyPathConfig_Fini() in pymain_impl() and then remove it, since it's a oneliner
_PyPathConfig_Init() now also initialize home and program_name: * Rename existing _PyPathConfig_Init() to _PyPathConfig_Calculate(). Add a new _PyPathConfig_Init() function in pathconfig.c which handles the _Py_path_config variable and call _PyPathConfig_Calculate(). * Add home and program_name fields to _PyPathConfig.home * _PyPathConfig_Init() now initialize home and program_name from main_config * Py_SetProgramName(), Py_SetPythonHome() and Py_GetPythonHome() now calls Py_FatalError() on failure, instead of silently ignoring failures. * config_init_home() now gets directly _Py_path_config.home to only get the value set by Py_SetPythonHome(), or NULL if Py_SetPythonHome() was not called. * config_get_program_name() now gets directly _Py_path_config.program_name to only get the value set by Py_SetProgramName(), or NULL if Py_SetProgramName() was not called. * pymain_init_python() doesn't call Py_SetProgramName() anymore, _PyPathConfig_Init() now always sets the program name * Call _PyMainInterpreterConfig_Read() in pymain_parse_cmdline_envvars_impl() to control the memory allocator * C API documentation: it's no more safe to call Py_GetProgramName() before Py_Initialize().
…0. (python#4681) * Revert "bpo-32030: _PyPathConfig_Init() sets home and program_name (python#4673)" This reverts commit af5a895. * Revert "bpo-32030: Fix config_get_program_name() on macOS (python#4669)" This reverts commit e23c06e. * Revert "bpo-32030: Add Python/pathconfig.c (python#4668)" This reverts commit 0ea395a. * Revert "bpo-32030: Don't call _PyPathConfig_Fini() in Py_FinalizeEx() (python#4667)" This reverts commit ebac19d. * Revert "bpo-32030: Fix Py_GetPath(): init program_name (python#4665)" This reverts commit 9ac3d88.
If the marshal or bytecode formats get changed, frozen.c needs to be updated as well. It can be easy to miss this step and not doing so can cause test_importlib to crash in mysterious ways. Add an explict unit test to make it easier to track down the problem.
…3940) Also addresses doc build failures documented in bpo-32200.
Previously, CO_NOFREE was set in the compiler, which meant it could end up being set incorrectly when code objects were created directly. Setting it in the constructor based on freevars and cellvars ensures it is always accurate, regardless of how the code object is defined.
Add import_find_and_load() helper function. The addition of the importtime option has made PyImport_ImportModuleLevelObject() large and so using a helper seems worthwhile. It also makes it clearer that abs_name is the only argument needed by _find_and_load().
…python#4570) instead of crashing due to a stack overflow. This perhaps will fix similar problems in other extension types.
The original algorithm tried to delegate the folding to the tokens so that those tokens whose folding rules differed could specify the differences. However, this resulted in a lot of duplicated code because most of the rules were the same. The new algorithm moves all folding logic into a set of functions external to the token classes, but puts the information about which tokens can be folded in which ways on the tokens...with the exception of mime-parameters, which are a special case (which was not even implemented in the old folder). This algorithm can still probably be improved and hopefully simplified somewhat. Note that some of the test expectations are changed. I believe the changes are toward more desirable and consistent behavior: in general when (re) folding a line the canonical version of the tokens is generated, rather than preserving errors or extra whitespace.
uuid.get_node() always must return a stable result. Also added a test for non-reproducibility of _random_getnode(). Original patch by Xavier de Gaye.
…rns. (python#4471) Also fixed searching patterns that could match an empty string.
…bpo-32030. (python#4681)" (python#4694) * Revert "bpo-32197: Try to fix a compiler error on OS X introduced in bpo-32030. (python#4681)" This reverts commit 13badcb. Re-apply commits: * "bpo-32030: _PyPathConfig_Init() sets home and program_name (python#4673)" commit af5a895. * "bpo-32030: Fix config_get_program_name() on macOS (python#4669)" commit e23c06e. * "bpo-32030: Add Python/pathconfig.c (python#4668)" commit 0ea395a. * "bpo-32030: Don't call _PyPathConfig_Fini() in Py_FinalizeEx() (python#4667)" commit ebac19d. * "bpo-32030: Fix Py_GetPath(): init program_name (python#4665)" commit 9ac3d88. * Fix compilation error on macOS
Patches are in 3.7.0a3 even if this update is not.
When tk event handling is driven by IDLE's run loop, a confusing and distracting queue.EMPTY traceback context is no longer added to tk event exception tracebacks. The traceback is now the same as when event handling is driven by user code. Patch based on a suggestion by Serhiy Storchaka.
…to some fields (python#4685) * Rather than raise TypeError, warn and call list() on the value. * Fix tests, revise NEWS and whatsnew text. * Revise documentation, a string is okay as well. * Ensure 'requires' and 'obsoletes' are real lists. * Test that requires and obsoletes are turned to lists.
…hon#4720) The undecodable file name cannot be created on macOS APFS file systems.
* Simplify _PyCoreConfig_INIT, _PyMainInterpreterConfig_INIT, _PyPathConfig_INIT macros: no need to set fields to 0/NULL, it's redundant (the C language sets them to 0/NULL for us). * Fix typo: pymain_run_statup() => pymain_run_startup() * Remove a few XXX/TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple implementation of the idea discussed in python/typing#432