Adjust background scale to prevent foreground from scaling out #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungilation
added a commit
to fungilation/react-native-parallax-scroll-view
that referenced
this pull request
Jun 19, 2018
…und) and the foreground to seemingly go outside the bounds of the background" when bouncy dragging down beyond top, by merging i6mi6#109
|
Great patch! Merged and tested in my branch and app WonderSwipe. Fixes the exact issue as described as I've been seeing as well, leaving a background (gray) gap on bouncy dragging beyond top on iOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue where
ParallaxScrollViewdoesn't scale the background enough on scroll to cover the new height, leading to lower layers of an app's UI to show up (such as a gray background) and the foreground to seemingly go outside the bounds of the background. This looks really bad, but adjusting the scaling by a factor of >= 1.4 seemed to work, though there might need to be a more dynamic value for different images.Here's an example of the bug.