Remove the client::conn combined-version types #2961
Conversation
See hyperium#2960 """ The public client API for 1.0 will be the version-specific types at client::conn::{http1, http2}. The combined version may exist in hyper-util, but at least it should be removed from hyper proper. Doing so isn't particularly complex, but it will mean fixing up all the tests. """
Michael-J-Ward
force-pushed
the
remove-combined-client-conn-types
branch
from
6a4a4e8 to
cd6f288
Compare
| self.h2_tx.is_extended_connect_protocol_enabled() | ||
| } | ||
| } | ||
| // impl<B> ClientTask<B> |
There was a problem hiding this comment.
Is this no longer needed? I think it's how HTTP/2 does it's websocket upgrades, right?
There was a problem hiding this comment.
conn::http2::ClientTask is not public, and the only existing public call site is here.
Line 370 in 9e8fc8f
There was a problem hiding this comment.
Oh I see, so probably something to add back to the http2::Connection type.
Switched per @seanmonstar's feedback in PR hyperium#2961 hyperium#2961
I noticed it wasn't being used at all anymore, so i wanted to remove the cruft.
|
Also - I apologize for just now seeing thee Commit Guidelines Should I wait until after review to rebase and squash them all into a single commit? |
This seems like the cleanes we can do without introducing a new trait or util.
Michael-J-Ward
force-pushed
the
remove-combined-client-conn-types
branch
from
dcb7aab to
49d4d85
Compare
Not a problem at all! Also note here in PULL_REQUESTS:
|
|
I've rebased this and started finishing the last bit in #2987. |
|
Finished in #2987, thanks so much! |
Resolves #2960
@seanmonstar ready to review, as I require your advice on the last item anyway
TODO:
http1::Connection::poll_without_shutdownclient::connmodule