Skip to content

Flatbuffer/Protobuf now able to receive rgba data #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Paulchen-Panther
Copy link
Member

Summary

Added the possibility to send RGBA data to the protobuffer/flatbuffer interface.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hey @Paulchen-Panther I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1606419163

@lgtm-com
Copy link

lgtm-com bot commented Dec 21, 2021

This pull request introduces 2 alerts when merging f17fada into c38ec60 - view on LGTM.com

new alerts:

  • 2 for Multiplication result converted to larger type

@hyperion-project
Copy link

Hey @Paulchen-Panther I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1615681161

@hyperion-project
Copy link

Hey @Paulchen-Panther I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1615685634

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2021

This pull request introduces 2 alerts when merging 59c4052 into c38ec60 - view on LGTM.com

new alerts:

  • 2 for Multiplication result converted to larger type

@Lord-Grey Lord-Grey self-requested a review December 23, 2021 19:50
@hyperion-project
Copy link

Hey @Paulchen-Panther I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1673744761

@hyperion-project
Copy link

Hey @Paulchen-Panther I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1674333435

@Paulchen-Panther Paulchen-Panther merged commit 98654e4 into hyperion-project:master Jan 9, 2022
@Paulchen-Panther Paulchen-Panther deleted the flatbuffer branch January 9, 2022 16:23
@Paulchen-Panther Paulchen-Panther mentioned this pull request Mar 16, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants