-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Moving to uv
instead of poetry
.
#2919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More in the standard, faster, seemingly better lockfile.
Nice 👍 |
This should be done automatically when you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi here! thanks for this, left some comments here and there, but mainly suggestions, so feel free to discard!
@@ -44,10 +44,14 @@ jobs: | |||
run: | | |||
sudo apt update | |||
sudo apt install python3.11-dev -y | |||
pip install -U pip uv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here maybe we could also benefit from the Python installation with uv install python 3.11
, as well as installing uv
from the standalone installer instead of pip
WDYT? reference at https://docs.astral.sh/uv/getting-started/installation/#standalone-installer
@@ -104,7 +104,7 @@ RUN case ${TARGETPLATFORM} in \ | |||
/opt/conda/bin/conda clean -ya | |||
|
|||
# Install flash-attention, torch dependencies | |||
RUN python3 -m pip install --upgrade pip && pip install numpy einops ninja joblib msgpack cmake --no-cache-dir && rm -rf /var/lib/apt/lists/* | |||
RUN python3 -m pip install --upgrade pip uv && pip install numpy einops ninja joblib msgpack cmake --no-cache-dir && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either adding uv
as a prefix to the follow-up pip install
command, or just removing the uv
installation for this stage, and install with pip
instead.
RUN python3 -m pip install --upgrade pip uv && pip install numpy einops ninja joblib msgpack cmake --no-cache-dir && rm -rf /var/lib/apt/lists/* | |
RUN python3 -m pip install --upgrade pip uv && uv pip install numpy einops ninja joblib msgpack cmake --no-cache-dir && rm -rf /var/lib/apt/lists/* |
p.s. besides the comment, shouldn't rm -rf /var/lib/apt/lists/*
be placed after an apt-get
somewhere for consistency, instead of after the pip install
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably bad copy-paste. I'm not touching anything non essential. This is a significant PR already
More in the standard, faster, seemingly better lockfile.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.