Rename serve to run, add asynchronous serve
#203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairingrey
approved these changes
May 14, 2019
|
LGTM! Will likely have to be rebased after #219 lands, but shouldn't take long. Also resolved the merge conflict (accepted the incoming changes), since EDIT: Ah, right, you'll also have to use the new |
fairingrey
suggested changes
May 14, 2019
|
Rebased and review applied! |
fairingrey
approved these changes
May 15, 2019
yoshuawuyts
added a commit
that referenced
this pull request
Nov 3, 2019
Signed-off-by: Yoshua Wuyts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
servetorun.App::servethat returns aFuture.Motivation and Context
This provides flexibility when composing app server with other futures. (cc #163)
How Has This Been Tested?
No new tests, existing tests pass.
Types of changes
Checklist: