Skip to content

Aslr #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Aslr #755

wants to merge 2 commits into from

Conversation

ler762
Copy link
Contributor

@ler762 ler762 commented Sep 16, 2018

having optimization, DEP and ASLR enabled if building with gcc seems like a Good Thing

I thought I'd made two separate branches
processrc for changing how init files were handled
aslr for enabling DEP and ASLR

but it looks like I fucked it up yet again & both are in this pull request :(

- add a new "-no-config" command line option to not read any initialization file

- refactor init file processing so that only one file is read
The search order is:
 1. command line "-config xxx" or "-no-config" options
 2. environment variable HTML_TIDY=xxx
 3. ~/.tidyrc
 4. /etc/tidy.conf
optimization, data execution prevention and address space layout randomization
all seem like Good Things To Have Enabled
@geoffmcl
Copy link
Contributor

@ler762 yes, seems you created the aslr branch from the processrc branch, so naturally will contain all... to keep them separate you must start with next when creating a new branch...

$ git checkout next
$ git checkout -b newbranch

Assuming you can separate these two issues... meantime this dual PR should be closed, since the processrc #754 is not yet agreed... see comments in #752, specifically PR

Concerning just commit 66b7ed5 not sure these should be added for every non-win os, and every version of gcc out there...

Seems there should be a way to do this externally, without forcing everyone down the same road... deciding for them...

Maybe if you opened an separate issue to discuss this... and first to see and understand what cmake uses by default... if not already included, why cmake chooses otherwise... what advantages... etc, etc, etc, ...

I would certainly need much more feedback on what is proposed... and prefer an issue to discuss... thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants