Messages increment

README/MESSAGES.md

@@ -1,8 +1,8 @@
 # Message System
 
-Tidy has quite complex warning/error messaging system. This is all about adding a **new** warning or error message to **libTidy**.
+Tidy has a quite complex warning/error report and footnote messaging system, but most of this complexity is completely hidden away from you in order to make adding messages as simple as possible. This particular README instructs you how to add a new warning/error report to **libTidy**.
 
-First assign the message a key value. This is done in `tidyenum.h`, in one of the two enumerations that are listed there.
+First assign the message a **key** value. This is done in `tidyenum.h`, in one of the two enumerations that are listed there.
 
  1. `tidyStrings` - starts with the value `TIDYSTRINGS_FIRST = 500`, and it must be first. This is the list of all strings available in Tidy with the exception of strings provided by other enumerations. **However** don't modify this enum directly. You'll modify a preprocessor macro instead.
 
@@ -12,24 +12,30 @@ First assign the message a key value. This is done in `tidyenum.h`, in one of th
 
  4. `TidyReportLevel` - And you probably won't need this, either.
 
-
-All enum values are only ever used by name within **libTidy** (and incidentally, should only ever be used by name in your client applications; never trust the value!), so feel free to enter new strings wherever they make the most sense. 
+All enum values are only ever used by name within **libTidy** (and incidentally, should only ever be used by name in your client applications; never trust the value!), so feel free to enter new strings in English alphabetical order (this helps us audit all of the strings from time to time). 
 
 As mentioned above, `tidyStrings` messages must be defined in one of the existing macros named like `FOREACH_...(FN)`, such as `FOREACH_DIALOG_MSG(FN)`. These macros ensure that another data structure used for localization and key lookup is updated automatically any time strings are added or removed, thus limiting the possibility of developer error.
 
 
 ## Step 1
 
-So in this case I want to add 3 warning messages: `BAD_SURROGATE_PAIR`, `BAD_SURROGATE_TAIL`, and `BAD_SURROGATE_LEAD`. Because these are error messages, they belong in the `tidyStrings` enum, and they fit into nicely into the macro beginning `FOREACH_DIALOG_MSG(FN)`. Please look at the comments for the category which indicates which output routine is used to generate the error, and keep this list in order!
+So in this case I want to add 3 warning messages: `BAD_SURROGATE_PAIR`, `BAD_SURROGATE_TAIL`, and `BAD_SURROGATE_LEAD`. Because these are error reports, they belong in the `tidyStrings` enum, and they fit into nicely into the macro beginning `FOREACH_REPORT_MSG(FN)`. Add the message key values into this macro, ensuring they are nested in the `FN()` syntax.
 
 
 ## Step 2
 
-The next step is adding a `format` string to `language_en.h`. This string may later be translated to various supported language strings, but at present it is important that the other language translated strings, like `language_fr.h`, `language_es.h`, etc, keep the same format order.
+The next step is adding a `format` string to `language_en.h`. This string may later be translated to various supported language strings, but even if you wish to support another language, it’s critical that you add the message format string to `language_en.h`, which serves as the base language for `LibTidy`.
 
-Where to add this seems a bit of a mess, but in general things are grouped by where they're used in `libTidy`, and often in alphabetical order within those groups. Here I've added them relative to where they were placed in the other enums and structs.
+Where to add this seems a bit of a mess, but in general things are grouped by where they're used in `libTidy`, and often in alphabetical order within those groups. Here I've added them in alphabetical order in the section where all of the other report messages are.
 
 Depending on which of the output routines you use (consult `message.c`) you may be able to use parameters such as `%u` and `%s` in your format strings. The available data is currently limited to the available message output routines. Please don't use `printf` for message output within **libTidy**.
 
+Note that Tidy doesn't currently support numbered `printf` parameters; parameters will be consumed in the order the report output function calls them.
+
+## Step 3
+
+The last step — hopefully — is adding the message key to the `dispatchTable[]` structure in `message.c`. This structure determines the `TidyReportLevel` (report severity) and message formatter (how to print the message). Then whenever you issue the report with `TY_(Report)()` or one of the existing convenience report functions, the correct message formatter will be used for the parameters that you specify.
+
+Please read the source code in `message.c` for help on how to choose a message formatter, or how to modify one of the existing message formatters if you need to accomodate a new function signature for your report.
 
 eof;

include/tidyenum.h

@@ -101,6 +101,7 @@ extern "C" {
  */
 #define FOREACH_MSG_MISC(FN) \
 /** File can't be opened */                        FN(FILE_CANT_OPEN)              \
+/** File can't be opened */                        FN(FILE_CANT_OPEN_CFG)          \
 /** Not a file */                                  FN(FILE_NOT_FILE)               \
 /** line %d column %d */                           FN(LINE_COLUMN_STRING)          \
 /** Document content looks like %s */              FN(STRING_CONTENT_LOOKS)        \
@@ -162,111 +163,100 @@ extern "C" {
  ** of errors and warnings.
  */
 #define FOREACH_REPORT_MSG(FN)        \
-    /* ReportAttrError */             \
+    FN(ADDED_MISSING_CHARSET)         \
     FN(ANCHOR_NOT_UNIQUE)             \
+    FN(APOS_UNDEFINED)                \
     FN(ATTR_VALUE_NOT_LCASE)          \
     FN(ATTRIBUTE_IS_NOT_ALLOWED)      \
+    FN(ATTRIBUTE_VALUE_REPLACED)      \
     FN(BACKSLASH_IN_URI)              \
     FN(BAD_ATTRIBUTE_VALUE_REPLACED)  \
     FN(BAD_ATTRIBUTE_VALUE)           \
-    FN(ATTRIBUTE_VALUE_REPLACED)      \
+    FN(BAD_CDATA_CONTENT)             \
+    FN(BAD_SUMMARY_HTML5)             \
+    FN(BAD_SURROGATE_LEAD)            \
+    FN(BAD_SURROGATE_PAIR)            \
+    FN(BAD_SURROGATE_TAIL)            \
+    FN(CANT_BE_NESTED)                \
+    FN(COERCE_TO_ENDTAG)              \
+    FN(CONTENT_AFTER_BODY)            \
+    FN(CUSTOM_TAG_DETECTED)           \
+    FN(DISCARDING_UNEXPECTED)         \
+    FN(DOCTYPE_AFTER_TAGS)            \
+    FN(DUPLICATE_FRAMESET)            \
+    FN(ELEMENT_NOT_EMPTY)             \
+    FN(ELEMENT_VERS_MISMATCH_ERROR)   \
+    FN(ELEMENT_VERS_MISMATCH_WARN)    \
+    FN(ENCODING_MISMATCH)             \
     FN(ESCAPED_ILLEGAL_URI)           \
     FN(FIXED_BACKSLASH)               \
+    FN(FOUND_STYLE_IN_BODY)           \
     FN(ID_NAME_MISMATCH)              \
+    FN(ILLEGAL_NESTING)               \
     FN(ILLEGAL_URI_CODEPOINT)         \
     FN(ILLEGAL_URI_REFERENCE)         \
     FN(INSERTING_AUTO_ATTRIBUTE)      \
+    FN(INSERTING_TAG)                 \
     FN(INVALID_ATTRIBUTE)             \
+    FN(INVALID_NCR)                   \
+    FN(INVALID_SGML_CHARS)            \
+    FN(INVALID_UTF8)                  \
+    FN(INVALID_UTF16)                 \
     FN(INVALID_XML_ID)                \
     FN(JOINING_ATTRIBUTE)             \
+    FN(MALFORMED_COMMENT)             \
+    FN(MALFORMED_DOCTYPE)             \
     FN(MISMATCHED_ATTRIBUTE_ERROR)    \
     FN(MISMATCHED_ATTRIBUTE_WARN)     \
     FN(MISSING_ATTR_VALUE)            \
+    FN(MISSING_ATTRIBUTE)             \
+    FN(MISSING_DOCTYPE)               \
+    FN(MISSING_ENDTAG_BEFORE)         \
+    FN(MISSING_ENDTAG_FOR)            \
     FN(MISSING_IMAGEMAP)              \
     FN(MISSING_QUOTEMARK)             \
-    FN(NEWLINE_IN_URI)                \
-    FN(PROPRIETARY_ATTR_VALUE)        \
-    FN(PROPRIETARY_ATTRIBUTE)         \
-    FN(REPEATED_ATTRIBUTE)            \
-    FN(UNEXPECTED_END_OF_FILE_ATTR)   \
-    FN(UNEXPECTED_EQUALSIGN)          \
-    FN(UNEXPECTED_GT)                 \
-    FN(UNEXPECTED_QUOTEMARK)          \
-    FN(WHITE_IN_URI)                  \
-    FN(XML_ID_SYNTAX)                 \
-    /* ReportEncodingError */         \
-    FN(INVALID_NCR)                   \
-    FN(INVALID_SGML_CHARS)            \
-    FN(INVALID_UTF16)                 \
-    FN(INVALID_UTF8)                  \
-    FN(VENDOR_SPECIFIC_CHARS)         \
-    /* ReportEncodingWarning */       \
-    FN(ENCODING_MISMATCH)             \
-    /* ReportEntityError */           \
-    FN(APOS_UNDEFINED)                \
     FN(MISSING_SEMICOLON_NCR)         \
     FN(MISSING_SEMICOLON)             \
-    FN(UNESCAPED_AMPERSAND)           \
-    FN(UNKNOWN_ENTITY)                \
-    /* ReportError */                 \
-    FN(BAD_CDATA_CONTENT)             \
-    FN(CANT_BE_NESTED)                \
-    FN(CONTENT_AFTER_BODY)            \
-    FN(DISCARDING_UNEXPECTED)         \
-    FN(DOCTYPE_AFTER_TAGS)            \
-    FN(ELEMENT_VERS_MISMATCH_ERROR)   \
-    FN(ELEMENT_VERS_MISMATCH_WARN)    \
-    FN(ILLEGAL_NESTING)               \
-    FN(INSERTING_TAG)                 \
-    FN(MALFORMED_COMMENT)             \
-    FN(MALFORMED_DOCTYPE)             \
-    FN(MISSING_DOCTYPE)               \
-    FN(MISSING_ENDTAG_BEFORE)         \
-    FN(MISSING_ENDTAG_FOR)            \
     FN(MISSING_STARTTAG)              \
     FN(MISSING_TITLE_ELEMENT)         \
+    FN(MOVED_STYLE_TO_HEAD)           \
+    FN(NESTED_EMPHASIS)               \
+    FN(NESTED_QUOTATION)              \
+    FN(NEWLINE_IN_URI)                \
     FN(NOFRAMES_CONTENT)              \
     FN(NON_MATCHING_ENDTAG)           \
+    FN(OBSOLETE_ELEMENT)              \
     FN(PREVIOUS_LOCATION)             \
+    FN(PROPRIETARY_ATTR_VALUE)        \
+    FN(PROPRIETARY_ATTRIBUTE)         \
     FN(PROPRIETARY_ELEMENT)           \
+    FN(REMOVED_HTML5)                 \
+    FN(REPEATED_ATTRIBUTE)            \
+    FN(REPLACING_ELEMENT)             \
     FN(REPLACING_UNEX_ELEMENT)        \
     FN(SPACE_PRECEDING_XMLDECL)       \
+    FN(SUSPECTED_MISSING_QUOTE)       \
     FN(TAG_NOT_ALLOWED_IN)            \
     FN(TOO_MANY_ELEMENTS_IN)          \
     FN(TOO_MANY_ELEMENTS)             \
-    FN(USING_BR_INPLACE_OF)           \
-    /* ReportFatal */                 \
-    FN(DUPLICATE_FRAMESET)            \
-    FN(SUSPECTED_MISSING_QUOTE)       \
+    FN(TRIM_EMPTY_ELEMENT)            \
+    FN(UNESCAPED_AMPERSAND)           \
+    FN(UNEXPECTED_END_OF_FILE_ATTR)   \
+    FN(UNEXPECTED_END_OF_FILE)        \
+    FN(UNEXPECTED_ENDTAG_ERR)         \
     FN(UNEXPECTED_ENDTAG_IN)          \
+    FN(UNEXPECTED_ENDTAG)             \
+    FN(UNEXPECTED_EQUALSIGN)          \
+    FN(UNEXPECTED_GT)                 \
+    FN(UNEXPECTED_QUOTEMARK)          \
     FN(UNKNOWN_ELEMENT_LOOKS_CUSTOM)  \
     FN(UNKNOWN_ELEMENT)               \
-    /* ReportMissingAttr */           \
-    FN(MISSING_ATTRIBUTE)             \
-    /* ReportNotice */                \
-    FN(CUSTOM_TAG_DETECTED)           \
-    FN(REPLACING_ELEMENT)             \
-    FN(TRIM_EMPTY_ELEMENT)            \
-    /* ReportSurrogateError */        \
-    FN(BAD_SURROGATE_LEAD)            \
-    FN(BAD_SURROGATE_PAIR)            \
-    FN(BAD_SURROGATE_TAIL)            \
-    /* ReportWarning */               \
-    FN(BAD_SUMMARY_HTML5)             \
-    FN(NESTED_EMPHASIS)               \
-    FN(NESTED_QUOTATION)              \
-    FN(OBSOLETE_ELEMENT)              \
-    FN(REMOVED_HTML5)                 \
+    FN(UNKNOWN_ENTITY)                \
+    FN(USING_BR_INPLACE_OF)           \
+    FN(VENDOR_SPECIFIC_CHARS)         \
+    FN(WHITE_IN_URI)                  \
     FN(XML_DECLARATION_DETECTED)      \
-    /* Report, mixed use */           \
-    FN(ADDED_MISSING_CHARSET)         \
-    FN(COERCE_TO_ENDTAG)              \
-    FN(ELEMENT_NOT_EMPTY)             \
-    FN(FOUND_STYLE_IN_BODY)           \
-    FN(MOVED_STYLE_TO_HEAD)           \
-    FN(UNEXPECTED_END_OF_FILE)        \
-    FN(UNEXPECTED_ENDTAG)             \
-    FN(UNEXPECTED_ENDTAG_ERR)
+    FN(XML_ID_SYNTAX)
 
 
 /** These are report messages added by Tidy's accessibility module.