Issue 456 - meta charset option #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls the work done by @marcoscaceres WIP #458 into the issue-456 branch, to complete the new add-meta-charset option.
|
See ongoing WIP discussion in #456... |
Continue WIP #456
It also fixes the addition of the constant 'http-equiv="Content-Type" attribute.
Manually fixed merge commits.
|
It looks good. There were some merge conflicts because of previous PR's that I fixed and pushed back. I also changed some of the wording in the new descriptions. In testing, this works fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have not been finding the time or energy to work more on this #456... but in all tests so far feels complete...
Maybe as a PR someone will find the time to test, and maybe smooth it out... thanks...